maxurl icon indicating copy to clipboard operation
maxurl copied to clipboard

Expired greasyfork link

Open o-r-i-z-u-r-u opened this issue 3 years ago • 6 comments

There's a link in Tamper Monkey to a greasy fork script

pictured here

and here

The link goes to https://greasyfork.org/en/scripts/36662

But it's expired and needs updating.

That's it, that's all, thanks.

o-r-i-z-u-r-u avatar Sep 21 '21 01:09 o-r-i-z-u-r-u

The issue is explained on #903. If anything you can always use https://web.archive.org/web/*/https://greasyfork.org/en/scripts/36662-image-max-url

DevWannabe-dot avatar Sep 21 '21 11:09 DevWannabe-dot

All good, as long as you're aware :)

What's up with the "disallowed external code"? Is it because some of the script is hosted on github?

o-r-i-z-u-r-u avatar Sep 22 '21 06:09 o-r-i-z-u-r-u

Yes. The script is safe but greasyfork has that scrict rule sadly.

All good, as long as you're aware :)

Nice, but if you meant to talk to the repo owner, it's not me, but it's ok!

DevWannabe-dot avatar Sep 22 '21 23:09 DevWannabe-dot

Thank you for reporting! Yes, I need to fix this, but I need to update the packaging scripts before in order for this to be possible.

Alternatively, I could perhaps simply link to the github repository, instead of the userscript. I'm not sure if they would accept this, but it would allow a single build to be used for all userscripts, instead of needing to maintain a special one for greasyfork.

qsniyg avatar Sep 23 '21 20:09 qsniyg

You can set up GitHub Actions to automatically compile your TypeScript sources to Userscript Javascripts. Then you can directly use this repository for releases and updates until Greasyfork issue gets resolved.

An example here: https://github.com/Trim21/webpack-userscript-template/tree/master/.github/workflows

LucioAmely avatar Dec 19 '21 02:12 LucioAmely

@LucioAmely Thanks! I'll take a closer look at GH Actions. The current build situation is far from ideal, and I need to improve it significantly.

qsniyg avatar Dec 20 '21 20:12 qsniyg

@qsniyg please remove GreasyFork link in README.rst file

https://github.com/qsniyg/maxurl#readme

The link doesn't work and is extremely misleading as it is the very first link in that document. image

wykopx avatar Feb 08 '23 22:02 wykopx

e x t r e m e l y m i s l e a d i n g

o-r-i-z-u-r-u avatar Feb 08 '23 23:02 o-r-i-z-u-r-u

e x t r e m e l y m i s l e a d i n g

Forgot to take your daily pills?

wykopx avatar Feb 09 '23 00:02 wykopx

actually yes, thanks for reminding me.

o-r-i-z-u-r-u avatar Feb 09 '23 00:02 o-r-i-z-u-r-u

e x t r e m e l y m i s l e a d i n g

Should it be

e-x-t-r-e-m-e-l-y-m-i-s-l-e-a-d-i-n-g

😀

realAzazello avatar Feb 10 '23 15:02 realAzazello

Sorry for getting to this so late. Fixed :)

qsniyg avatar Feb 10 '23 19:02 qsniyg