xlsx icon indicating copy to clipboard operation
xlsx copied to clipboard

feat: add support for ST_SheetState (visibility)

Open flhorizon opened this issue 2 years ago • 3 comments

Allow parsing and managing the visibility of sheets.

I've tried to be as conservative as possible but perhaps xlSheets would benefit from having it's own ADT rather than expanding sheets tuple?

edit more details:

Although it feels clunkier to extend _xlSheets tuples to include the ST_State, it's a sheet attribute on the same level as the name.

I first though about adding a Worksheet field for the state (and perhaps that would've been better?) but reading how <sheet ... > attributes are handled I've decided to track it at the same level as sheet names

Tell me how you feel about it :) it would simplify _xlSheets lenses a great deal to rather have it as _wsState or something.

flhorizon avatar Aug 12 '22 18:08 flhorizon

Another problem with microlens, will you take a look?

qrilka avatar Aug 15 '22 21:08 qrilka

Hello! I've fixed the compilation errors with microlens

flhorizon avatar Aug 22 '22 09:08 flhorizon

Would you mind resolving the conflict as well?

qrilka avatar Aug 22 '22 16:08 qrilka

Hey

So I've moved the state to WorkSheet, addressed other comments and added a few related tests

flhorizon avatar Aug 28 '22 20:08 flhorizon