desktop icon indicating copy to clipboard operation
desktop copied to clipboard

bug(dataset): "show in finder/explorer" in menu shouldn't work if a dataset isn't checked out

Open ramfox opened this issue 4 years ago • 3 comments

from technickle on discord:

"Also the "Dataset -> Show in Explorer" menu command just opens the Qri Desktop folder in %appdata% on my windows machine if you haven't done a checkout yet. So maybe it should bump you to the checkout prompt if you haven't done it first."

We shouldn't allow the "Show in Explorer" menu command if the dataset is not checked out

ramfox avatar Sep 16 '20 15:09 ramfox

@dustmop or @b5 , unfortunately I can't repro this on the mac version. It is correctly enabled/disabled when we have a non-checked out dataset or we have a checked out dataset. The logic as written is sound.

We do base whether we enable the "show in explorer" menu on fsiPath != ''. Could the windows backend be sending back something different for fsiPath then the mac backend, potentially creating a situation where there is content in the fsiPath field?

Any chance someone can pull fix_various_bugs on a windows machine, add a dataset, and look at the menu for Dataset => Show in Explorer before and after checking out the dataset?

ramfox avatar Sep 20 '20 18:09 ramfox

I am unable to reproduce this in Windows. When I have a dataset that isn't checked out, the "Show in explorer" option is disabled.

dustmop avatar Sep 21 '20 22:09 dustmop

Found an additional bug around this issue. In the menu items that get generated when you right-click a component, it always says 'Open in Finder', need to fix that. Once that is fixed I think we should close this issue as we can't repro the original problem.

ramfox avatar Oct 27 '20 18:10 ramfox