desktop
desktop copied to clipboard
refactor(types): LogItem & VersionInfo
https://github.com/qri-io/qri/pull/1221
Let's create types that more closely match the responses we are going to get from the backend:
LogItem: { ...LogItem.VersionInfo, commitMessage: string commitTitle: string }
ListItem: VersionInfo
Just to make sure we're on the same page, LogItem does not contain a VersionInfo, it embeds a VersionInfo. So we won't have:
LogItem = {
"versionInfo": {
"name": "my_dataset",
"path": "QmAbCd",
... // other fields of VersionInfo
},
"commitMessage": "...",
"commitTitle": "..."
}
instead the intention is that we will have:
LogItem = {
"name": "my_dataset",
"path": "QmAbCd",
... // other fields from VersionInfo
"commitMessage": "...",
"commitTitle": "..."
}
This was a mistake that wasn't caught on the original PR. See: https://github.com/qri-io/qri/issues/1218#issuecomment-603946810
Not sure if that's what your ...LogItem.VersionInfo
syntax meant, just wanted to check.