Hanfei Shen

Results 24 comments of Hanfei Shen

Hi @brettdh @snim2 , thanks for giving the detailed feedbacks. While I was trying Marge on my macOS, I found: 1. `nix-shell` doesn't even work on macOS. https://github.com/NixOS/nixpkgs/issues/91748 and https://github.com/NixOS/nixpkgs/issues/104580....

@brettdh Pushed a new commit to #291 to introduce poetry.

Hi, we are seriously considering removing nix in marge for the following reasons: 1. It brings lots of unnecessary complexity to this project 2. It's hard for developers, especially new...

@nejch thanks for the feedback. I've submitted a new MR to upgrade the dependencies and fix lint warnings introduced by the latest linters. However other parts, e.g. testing with more...

Hi, wondering if this is still needed for v0.9.5+?

Interesting. We've been using v0.9.5 for 2+ months at Smarkets, and not seen this again. I'll leave this open in case anyone encounters this issue with the latest version again.

No. We don't allow pushing to master. But wait, is that the expected behavior to give up merging when there are new commits in master?

@valentindavid Thanks for the contribution. Changing the branch name for branch will be a breaking change. Would you please add a configuration that is disabled by default?

Thank you @bigc2000 for contributing this PR. Might need some help from the community to verity this since internally we don't use fork.

Just upgraded to 8.3 and 6.11. ``` root@pve:~# uname -a Linux pve 6.11.0-1-pve #1 SMP PREEMPT_DYNAMIC PMX 6.11.0-1 (2024-10-23T15:32Z) x86_64 GNU/Linux root@pve:~# lspci | grep -i vga 00:02.0 VGA compatible...