Lu Niu
Lu Niu
Thanks! looks there are more issues related to encoding support which are not covered before.
@8dukongjian does your team have bandwidth to take No.9 in bugs? currently no one is working on that.
@yingsu00 thanks. I haven't got the time for a detail check. I am wondering whether https://github.com/facebookincubator/velox/blob/8567d4d823ba3f205c001eab6081343fabe89408/velox/dwio/parquet/reader/PageReader.cpp#L608 or some of it can be reused.
@yma11 Thanks! could you create a issue and share the stacktrace and file to reproduce there? also, are you going to work on that?
@jaystarshot I was about to add unit test for https://github.com/facebookincubator/velox/pull/9223 . Let me know whether I should proceed.
We've implemented testing velox parquet using presto unit test. Here is the mini design doc: https://gist.github.com/qqibrow/689ed97b91cc0b58337be96a86291301
Here are some of the issues we discovered: add example file to reproduce: https://github.com/facebookincubator/velox/issues/7002 https://github.com/facebookincubator/velox/issues/7617 https://github.com/facebookincubator/velox/issues/7776 https://github.com/facebookincubator/velox/issues/7777 https://github.com/facebookincubator/velox/issues/7778 https://github.com/facebookincubator/velox/issues/7779