echoplexus icon indicating copy to clipboard operation
echoplexus copied to clipboard

Refactor the code

Open qq99 opened this issue 10 years ago • 5 comments

Just going over some of the files now, there's a lot that's stale or could be improved (at least syntactically) from the coffeescript rewrite. There's also a lot of cases where data is being sent across (room name) in the body of the message, but this isn't even necessary as it should just be inferred from the namespaced events

qq99 avatar Feb 09 '14 07:02 qq99

Previous discussions: https://github.com/qq99/echoplexus/issues/122 https://github.com/qq99/echoplexus/issues/121

qq99 avatar Aug 10 '14 01:08 qq99

Are you considering an (almost) rewrite or something else? I think we could also take a look at this, i have been using it in some personal projects and i love the added code separation it adds, while not losing alot of the core stuff from backbone.

jamiees2 avatar Aug 14 '14 14:08 jamiees2

I've heard a lot of good thing about Marionette As for client side, it would definitely be nice to have a pretty big re-write Server code is not so messy, but client code has really exploded in complexity & has very few tests

qq99 avatar Aug 17 '14 00:08 qq99

Why not both?

On Sun, Aug 17, 2014 at 2:07 AM, Anthony Cameron [email protected] wrote:

I've heard a lot of good thing about Marionette As for client side, it would definitely be nice to have a pretty big re-write Server code is not so messy, but client code has really exploded in complexity & has very few tests

— Reply to this email directly or view it on GitHub https://github.com/qq99/echoplexus/issues/198#issuecomment-52409501.

ghost avatar Aug 19 '14 00:08 ghost

Works for me :D

qq99 avatar Aug 19 '14 02:08 qq99