deprecation-detector icon indicating copy to clipboard operation
deprecation-detector copied to clipboard

Add Blacklist for deprecations

Open slde-robin opened this issue 9 years ago • 8 comments

If your project uses a deprecation heavily your whole output is full of it. We should add a configuration to blacklist some deprecations.

slde-robin avatar Oct 17 '15 10:10 slde-robin

It might also be useful to be able to exclude certain files or directories.

umulmrum avatar Oct 17 '15 11:10 umulmrum

i agree on excluding certain files or directories, but i'm not sure about a deprecation blacklist. I don't like the idea of extensive option usage like #17 provides as solution. maybe a blacklist by config file? a config file would make it easy to exclude files and directories as well.

chr-hertel avatar Oct 17 '15 19:10 chr-hertel

The implementation in #17 provides an option to implement a file/folder exclude as well. How you define the filter options can be decided for every filter separately. I think, the option to exclude certain calls is suited for being configured on the command line, but I am open for discussion on that matter. The reason I think this is a good option is that the normal use case will probably be:

  • run the checker
  • see excessive use of one specific, deprecated method call
  • filter that call out on a consecutive run to get a better overview of the remaining problems

Adding such filter to a config file wouldn't be a convenient way to go, and moreover would probably encourage ignoring certain errors by default and forgetting about it.

bestform avatar Oct 17 '15 19:10 bestform

after #17 we still need the implementation for other violations. May we should also add an output if a specific deprecation is filtered.

MarvinKlemp avatar Oct 17 '15 20:10 MarvinKlemp

Adding active filters to the output is a good idea.

bestform avatar Oct 17 '15 20:10 bestform

@bestform do you want to add the missing filters ?

MarvinKlemp avatar Oct 30 '15 11:10 MarvinKlemp

@MarvinKlemp what do you mean exactly? The filters itself (if so: is there a list of missing filters?) or the information about active filters in the output?

bestform avatar Oct 31 '15 12:10 bestform

if you want both :laughing: But IMO we should wait until #45 is merged

MarvinKlemp avatar Nov 03 '15 18:11 MarvinKlemp