deprecation-detector
deprecation-detector copied to clipboard
qossmic
Include vendor deprecation warnings
Firstly, thanks for the awesome tool!
I've run it against my codebase with:
./deprecation-detector check $PROJECT/src $PROJECT/vendor
It found lots of helpful things to cleanup. Now when I run it, nothing is found. However, if I go to one of my views, I do see deprecation warnings in the profiler related to my Twig dependency. It's not my issue, but the related deprecation is discussed here: https://github.com/twigphp/Twig/issues/2267
If there is any more info I can provide that would be helpful, please let me know.
Actually the tool doesn't check if there are any deprecations in your twig templates.
Right, that's the reason I opened the issue, so there could be some discussion about it.
Do you think this type of functionality could be added? I'm thinking beyond templates specifically. Do you think the tool could find and report all deprecation warnings that the symfony profiler would report? That would be the ultimate goal, I think.
Sent from a phone
On Feb 28, 2017, at 12:24 AM, slde-robin [email protected] wrote:
Actually the tool doesn't check if there are any deprecations in your twig templates.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
The profiler gathers the warnings by actually executing the code. The detector does not execute the code.
To add Twig support we would need a twig parser and so on... IMO thats too much.
But you could check your compiled Twig templates in the cache dir for deprecations. Right now I don't have the time to test that myself. It would be great if you could test that and give me review
Awesome, thanks for the very helpful info.
Sent from a phone
On Mar 1, 2017, at 5:25 AM, slde-robin [email protected] wrote:
The profiler gathers the warnings by actually executing the code. The detector does not execute the code.
To add Twig support we would need a twig parser and so on... IMO thats too much.
But you could check your compiled Twig templates in the cache dir for deprecations. Right now I don't have the time to test that myself.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.