logback icon indicating copy to clipboard operation
logback copied to clipboard
verified publisher icon qos-ch

LOGBACK-1558 - Fix for code that fails existing tests

Open multicatch opened this issue 4 years ago • 0 comments

This pull request relates to LOGBACK-1558.

I have implemented a fix for the code that fails the following tests:

  • ch.qos.logback.classic.joran.JoranConfiguratorTest,
  • ch.qos.logback.core.rolling.helper.RollingCalendarTest

RollingCalendar had an issue when detecting collisions - there was a case when the first day of a year is not exactly within the first week of a year.

JoranConfigurator did not correctly resolve appender refs (eg. AsyncAppenderBase was started too early, before all appenders were attached to it) and I delayed the start of appenders after the whole configuration is built.

multicatch avatar May 17 '21 09:05 multicatch