qore icon indicating copy to clipboard operation
qore copied to clipboard

cmake builds: binary modules builds are broken when is cmake built used for qore. QORE_VERSION_CODE check is potentially wrong when using one digit VERSION_SUB

Open pvanek opened this issue 8 years ago • 5 comments

affecting only internal buildservice for now

pvanek avatar Sep 25 '17 06:09 pvanek

example:

pvanek@spongebob:~/src/qore/module-xml> if test 90 -lt 812; then echo "foo"; fi
foo

this is correct:

pvanek@spongebob:~/src/qore/module-xml> if test 900 -lt 812; then echo "foo"; fi

pvanek avatar Sep 25 '17 06:09 pvanek

The close was automatic because of the commit message in @pvanek's pull request. The issue is not fully fixed yet.

omusil24 avatar Sep 25 '17 12:09 omusil24

@omusil24 can u pls check?

sejvlond avatar Apr 15 '19 12:04 sejvlond

@sejvlond Yeah. Hopefully tomorrow.

omusil24 avatar Apr 15 '19 12:04 omusil24

@sejvlond This problem is still present. It only affects modules built with autotools though AFAIK. Which for qore-test-base currently means all the database modules (except ODBC) - mysql, oracle, pgsql, sybase...

Buildservice is maybe using the autotools build for some other modules, not sure. Also, for Qore 0.8.x autotools is used more, but because the version is 13 or something double-digit, it's not a problem.

Since we want to move to cmake for all builds, I wouldn't fix this and instead just fix/add missing cmake builds to the rest of the modules.

omusil24 avatar Apr 17 '19 04:04 omusil24