ngx-inline-editor icon indicating copy to clipboard operation
ngx-inline-editor copied to clipboard

`ng build --prod` AOT compilation errors with `fullTemplateTypeCheck: true`

Open KeithGillette opened this issue 6 years ago • 3 comments

Angular 5.2 introduces a new AoT compiler fullTemplateTypeCheck option to perform a more thorough type check on templates. It is expected that this option will default to true in a future version: https://blog.angular.io/angular-5-2-now-available-312d1099bd81

Running ng build --prod with tsconfig.app.json updated with the template checks:

"angularCompilerOptions": {
  "fullTemplateTypeCheck": true
},

produces the following errors:

node_modules/@qontu/ngx-inline-editor/ngx-inline-editor.d.ts.InlineEditorComponent.html(1,579): : Argument of type '{ event: any; state: InlineEditorState; }' is not assignable to parameter of type 'ExternalEvent'.
  Types of property 'state' are incompatible.
    Type 'InlineEditorState' is not assignable to type 'InlineEditorStateOptions'.
      Property 'value' is private in type 'InlineEditorState' but not in type 'InlineEditorStateOptions'.
node_modules/@qontu/ngx-inline-editor/ngx-inline-editor.d.ts.InlineEditorComponent.html(1,769): : Argument of type '{ event: any; state: InlineEditorState; }' is not assignable to parameter of type 'ExternalEvent'.
  Types of property 'state' are incompatible.
    Type 'InlineEditorState' is not assignable to type 'InlineEditorStateOptions'.
  • InlineEditor: 0.2.0-alpha.12
  • Angular: 5.2.6
  • Angular CLI: 1.7.1
  • TypeScript: 2.7.2
  • Node.JS: 8.9.3

KeithGillette avatar Mar 01 '18 14:03 KeithGillette

@xxxtonixxx — I made a brief attempt to diagnose & resolve this issue to offer a PR, but can't get the build script to run. The project doesn't seem to include @angular/cli in devDependencies. Any guidance?

KeithGillette avatar Mar 28 '18 12:03 KeithGillette

@KeithGillette how did you solve this proplem? Seems this project is dead....

rovico avatar Jan 18 '19 12:01 rovico

I have no solution to this problem, as I have been waiting for the new build process promised by @xxxtonixxx before I return to attempting to implement a fix. Unfortunately, I agree that the project does seem moribund, @rovico, as I have not heard from the maintainers since September 2018.

KeithGillette avatar Jan 18 '19 13:01 KeithGillette