QuantumOpticsBase.jl icon indicating copy to clipboard operation
QuantumOpticsBase.jl copied to clipboard

Import coherentstate, thermalstate, displace, squeeze, wigner from QuantumInterface

Open Krastanov opened this issue 1 year ago • 2 comments

Now that https://github.com/qojulia/QuantumInterface.jl/pull/29 is merged, it would make sense to rely on that namespace for these helper functions.

Krastanov avatar Sep 08 '24 18:09 Krastanov

ping @apkille

Krastanov avatar Sep 08 '24 18:09 Krastanov

@krastanov we get type piracy doing this, as the first four functions you mentioned dispatch on FockBasis, which is defined in QuantumInterface rather than QuantumOpticsBase. I missed this because FockBasis is not imported in the root file of QOBase and I was quick to assume it was defined somewhere in the package. Any ideas for fixing this?

apkille avatar Sep 09 '24 02:09 apkille