Quim Muntal

Results 74 comments of Quim Muntal

> Thanks for all of this work @qmuntal ! Is there more to be done here, or can we close this issue at this point? I haven't close it yet...

While investigating #62887 I found out that, on windows/amd64 using internal linking, the Go linker doesn't merge .pdata/.xdata sections from host object files generated by the C compiler. This means...

> Hi @qmuntal , what is the status for this now? Is there more to do? Should we bump to Go 1.23? Thanks. windows/arm64 work still missing. I'll probably won't...

> Builders are back up. I'm going to keep the issue open for a bit longer in case other problems arise, but for now it looks like things are working....

> @qmuntal I don't see the `TRY=` comment on that CL? The alias does exist: https://cs.opensource.google/go/x/build/+/master:dashboard/builders.go;l=103;drc=faea4fa6b0c3ed3cd8232c6eb6742d3bcb3f867d. Here it is: https://go-review.googlesource.com/c/go/+/452995/comments/ba8287b7_ae1d5bac

The lack of frame pointer in `asmcgocall` is also breaking stack unwinding on WinDbg (using the prototype from #57302). I've tried with gdb, and it's also broken: ```cmd Thread 1...

@ianlancetaylor @cherrymui `asmcgocall` does not have a frame pointer even it being a non-leaf function due to condition 2 in this code: https://github.com/golang/go/blob/1ba7341cb21d9edb2a04eb0b24b3af71899b35fc/src/cmd/internal/obj/x86/obj6.go#L609-L626 `asmcgocall` seems to be doing well with...

> But I'm not sure we should blindly hide stack transitions for other low-level unwinders. I don't expect Go to hide wrappers and stack transitions to external unwinders, if it...

@donatocayurin please use reactions to show support for an issue instead of posting a new comment with just an emoji. This way we keep the conversation history cleaner.

For the record: as of today (go1.20), [syscall.SyscallN](https://pkg.go.dev/syscall?GOOS=windows#SyscallN) is internally limited to 42 arguments, even though it accepts a variadic input. https://github.com/golang/go/blob/9894ded19417fbc40420dc813d3c6606348ad31b/src/runtime/syscall_windows.go#L528-L533