qmk_firmware
qmk_firmware copied to clipboard
feat: adding support to HLB H60-H and H60-S pcbs
Adding support of HLB proprietary pcbs HL60-H and HL60-S (60%) Will be sold with upcoming GB PoorKoi 2 keyboard.
Types of Changes
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement/optimization
- [X] Keyboard (addition or update)
- [X] Keymap/layout (addition or update)
- [ ] Documentation
Issues Fixed or Closed by This PR
Checklist
- [X] My code follows the code style of this project: C, Python
- [X] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [X] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
All changes made with vid updated to the same value as the hyperbola pr - is it possible to validate the review since there is no more custom rgb code ?
Hi, would it be possible to resume review @zvecr , all request changes have been done weeks ago ?