qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add reverse layout to SouthPad v2

Open MatchstickWorks opened this issue 2 months ago • 5 comments

Description

Addition of an alternative layout to reverse the number layout to match a standard layout numpad

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [x] Keymap/layout (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

MatchstickWorks avatar Oct 06 '25 20:10 MatchstickWorks

to match a standard layout numpad

Im a bit confused on what this PR aims to accomplish. Running qmk info -m -kb matchstickworks/southpad/rev2:

Matrix for "LAYOUT":
┌──┐┌──┐┌──┐┌──┐
│0A││0B││0C││0D│
└──┘└──┘└──┘└──┘
┌──┐┌──┐┌──┐┌──┐
│1A││1B││1C││1D│
└──┘└──┘└──┘└──┘
┌──┐┌──┐┌──┐┌──┐
│2A││2B││2C││2D│
│  │└──┘└──┘└──┘
│  │┌──┐┌──┐┌──┐
│  ││3B││3C││3D│
└──┘└──┘└──┘└──┘
┌──┐┌──┐┌──┐┌──┐
│4A││4B││4C││4D│
│  │└──┘└──┘└──┘
│  │┌──┐┌──────┐
│  ││5B││5D    │
└──┘└──┘└──────┘
Matrix for "LAYOUT_reverse":
┌──┐┌──┐┌──┐┌──┐
│0A││0B││0C││0D│
└──┘└──┘└──┘└──┘
┌──┐┌──┐┌──┐┌──┐
│1A││1B││1C││1D│
└──┘└──┘└──┘└──┘
┌──┐┌──┐┌──┐┌──┐
│2A││2B││2C││2D│
│  │└──┘└──┘└──┘
│  │┌──┐┌──┐┌──┐
│  ││3B││3C││3D│
└──┘└──┘└──┘└──┘
┌──┐┌──┐┌──┐┌──┐
│4A││4B││4C││4D│
│  │└──┘└──┘└──┘
│  │┌──┐┌──────┐
│  ││5B││5D    │
└──┘└──┘└──────┘

These are idential.

If the intention is to just swap the order of keys from "321" to "123" then this change shouldn't touch the keyboard.json and should be just a keymap using the existing LAYOUT layout macro?

zvecr avatar Oct 08 '25 01:10 zvecr

@zvecr Does the Json not affect what's shown in config.qmk.fm? If it doesn't, then yes, the json probably can revert.

MatchstickWorks avatar Oct 08 '25 01:10 MatchstickWorks

In terms of the describing the physical layout, yes it uses the keyboard.json. The label properties do not map to keycodes and are completely ignored by configurator.

Default mapping of keys is done by https://github.com/qmk/qmk_configurator/blob/master/public/keymaps/m/matchstickworks_southpad_rev2_default.json where it only supports a single default keymap.

zvecr avatar Oct 08 '25 02:10 zvecr

Excellent, thanks for the explainer!

I've reverted the json edits

MatchstickWorks avatar Oct 08 '25 04:10 MatchstickWorks

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Nov 23 '25 02:11 github-actions[bot]