qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

feat: Make wait before reset configurable

Open emolitor opened this issue 5 months ago • 2 comments

Description

Currently quantum.c shutdown_quantum has a hard coded wait_ms(250) for, among other things, to allow the shutdown chime to complete playing. This change makes that value configurable.

Types of Changes

  • [x] Core
  • [ ] Bugfix
  • [x] New feature
  • [ ] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [ ] Keymap/layout (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

emolitor avatar Jul 12 '25 19:07 emolitor

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Oct 16 '25 02:10 github-actions[bot]

Zero files changed?

tzarc avatar Oct 27 '25 04:10 tzarc

Closing as PR is now empty, and #25859 supersedes the original changeset.

zvecr avatar Dec 08 '25 13:12 zvecr