qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Framework16 ANSI Keyboard PR revival

Open peepeetee opened this issue 7 months ago • 1 comments

Description

I took interest in #21722 and am trying to revive it.

Types of Changes

Add the white backlight ANSI keyboard for Framework 16

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout (addition or update)
  • [x] Documentation

Issues Fixed or Closed by This PR

  • #21722
  • #23907

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

peepeetee avatar May 06 '25 05:05 peepeetee

the directory structure is keyboards/framework/laptop16/ansi/ ansi can and will be replaced with iso and jis

but the lint job lints on keyboards/framework/laptop16 as well as keyboards/framework/laptop16/ansi/. How should I stop it from running on keyboards/framework/laptop16? Should the directory structure be reorganized somehow? or should I disable linting on the directory? or is it telling me to add a keyboard.json to the directory? but it isn't a keyboard

peepeetee avatar May 06 '25 11:05 peepeetee

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Aug 06 '25 02:08 github-actions[bot]

Status: Working and used on my unit. Still figuring out how to reduce custom code to ease maintenance.

peepeetee avatar Aug 06 '25 02:08 peepeetee

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Sep 22 '25 02:09 github-actions[bot]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

github-actions[bot] avatar Oct 23 '25 02:10 github-actions[bot]

poking to keep alive

peepeetee avatar Oct 23 '25 12:10 peepeetee