qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Adding a new keyboard - Slothie60

Open makkomise opened this issue 10 months ago • 8 comments

Description

QMK-support for my passion project, Slothie60!. Added keymap and json-file.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

makkomise avatar Feb 18 '25 22:02 makkomise

Thank you so much for the suggestions! They all should be fixed now. IDK why the CI build shows failed, even though it does compile atleast on my end

makkomise avatar Feb 19 '25 07:02 makkomise

Your definition of LAYOUT_60_iso does not match the 60_iso community layout, therefore building the default_60_iso keymap fails.

Apparently your PCB supports multiple layout options, so you need to provide several layout definitions (including LAYOUT_60_iso, if it's possible to build that exact layout with your PCB, otherwise you should use a different name and remove community_layouts).

sigprof avatar Feb 19 '25 08:02 sigprof

Screenshot 2025-02-19 131900

I've updated the layouts and it gives me these errors in msys now, even though it does still compile. I've tried looking at documentation and google, but i didn't get certain answer on why these errors happen. Is this something that's okay or could you give me any help on what to do?

makkomise avatar Feb 19 '25 11:02 makkomise

You need to provide the matrix positions ("matrix": [0, 0] and the like) in all layouts, not just LAYOUT_all (QMK can't deduce that info from another layout).

sigprof avatar Feb 19 '25 11:02 sigprof

You need to provide the matrix positions ("matrix": [0, 0] and the like) in all layouts, not just LAYOUT_all (QMK can't deduce that info from another layout).

But i do have those in the keyboard.json. Do they also need to be provided elsewhere?

makkomise avatar Feb 19 '25 11:02 makkomise

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jun 13 '25 02:06 github-actions[bot]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Sep 04 '25 02:09 github-actions[bot]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Nov 17 '25 02:11 github-actions[bot]