qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Fix space cadet auto shift interaction

Open AndrewMoscoe opened this issue 5 months ago • 4 comments

Fix for this bug: https://github.com/qmk/qmk_firmware/issues/20978

Enable space cadet shift - left shift (, right shift ) Enable auto shift

Press shift, press a letter, and release shift before releasing the letter.

When using left shift, the ( will be before the letter. When using right shift, the ) will be after the letter.

If you release shift after releasing the letter, the () will not print, and the keyboard works as you would want.

Description

Fix space cadet-auto shift interaction bug

Types of Changes

  • [ ] Core
  • [x] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [ ] Keymap/layout (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

  • https://github.com/qmk/qmk_firmware/issues/20978

Checklist

  • [x ] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

AndrewMoscoe avatar Sep 26 '24 15:09 AndrewMoscoe