qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Fix build failure on zsa/moonlander with DYNAMIC_MACRO_ENABLE

Open Nebuleon opened this issue 1 year ago • 0 comments

Description

In current develop, zsa/moonlander fails to build if DEFERRED_EXEC_ENABLE and DYNAMIC_MACRO_ENABLE are both defined:

keyboards/zsa/moonlander/moonlander.c: In function 'dynamic_macro_record_start_kb':
keyboards/zsa/moonlander/moonlander.c:48:1: error: expected ';' before '}' token
   48 | }
      | ^
keyboards/zsa/moonlander/moonlander.c: In function 'dynamic_macro_record_end_kb':
keyboards/zsa/moonlander/moonlander.c:59:1: error: expected ';' before '}' token
   59 | }
      | ^

Semicolons are actually missing from the preceding lines, which read

return true

and

return false

and this PR fixes the build.

Types of Changes

  • [x] Core
  • [x] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Nebuleon avatar Aug 23 '24 04:08 Nebuleon