qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

`atlantis/ak81_ve`: move RGB Matrix LED config to data driven

Open fauxpark opened this issue 1 year ago • 2 comments

Description

⚠ atlantis/ak81_ve: led_config: ak81_ve.c: Number of columns in row 0 (14) does not match matrix (15)

image image

Should be mostly correct, although the ordering of the underglow LEDs is unknown so I just made something up.

CC @fOmey and possibly @peepeetee, could one of you please verify the ordering here?

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [x] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark avatar Jul 13 '24 13:07 fauxpark

I don't have a device, so I don't think I know or knew.

I did get atlantis into our discord server, consider pinging them there?

peepeetee avatar Jul 13 '24 22:07 peepeetee

No worries. I thought you might have some insight based on this comment on the original PR.

fauxpark avatar Jul 13 '24 22:07 fauxpark