qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard
verified publisher icon qmk

adds support for ws0010 based character oled displays

Open NewAbbreviations950 opened this issue 1 year ago • 12 comments

Description

Added support for ws0010 based 16x2 character OLED screens

Used the hd77480 lcd driver as reference and ported it to the ws0010 chip used in OLED displays. Most of the commands are the same but the init sequence is quite different. It is integrated in the same manner as the lcd driver in that you define the driver in your rules.mk file and define the pins in config.h. The docs are also located where the hd77480 docs are.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [x ] New feature
  • [ ] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ x] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • [ x] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

NewAbbreviations950 avatar Jul 13 '24 07:07 NewAbbreviations950

Is it correct to merge this into the develop branch? I thought I read that in the guidlines but now i'm doubting myself.

NewAbbreviations950 avatar Jul 15 '24 11:07 NewAbbreviations950

Is it correct to merge this into the develop branch? I thought I read that in the guidlines but now i'm doubting myself.

Yes. New features like this go to develop first.

drashna avatar Jul 15 '24 18:07 drashna

You've pulled in some unrelated changes, please revert this.

fauxpark avatar Jul 16 '24 03:07 fauxpark

Is that better?

NewAbbreviations950 avatar Jul 17 '24 19:07 NewAbbreviations950

i'm not 100% sure what lint wants me to do here. Thought it better to ask than just starting to change things.

NewAbbreviations950 avatar Jul 25 '24 07:07 NewAbbreviations950

Look at the job output, it produces a diff.

fauxpark avatar Jul 25 '24 07:07 fauxpark

some of the lines don't have a + or a - next to them? Do they not need formatting? Are they just for reference or something? Sorry for all the questions, i'm learning.

NewAbbreviations950 avatar Jul 25 '24 08:07 NewAbbreviations950

I recommend you read up a bit on what diffs are. https://stackoverflow.com/questions/2529441/how-to-read-the-output-from-git-diff

fauxpark avatar Jul 25 '24 08:07 fauxpark

thanks, that was a good thread :)

NewAbbreviations950 avatar Jul 25 '24 08:07 NewAbbreviations950

should be fixed now :)

NewAbbreviations950 avatar Aug 05 '24 11:08 NewAbbreviations950

On hold for the moment; from internal discussion there seems to be very limited use cases for this OLED to be used. We're bringing in the concept of "community modules" where certain functionality is kept external to QMK -- the thought is that this would be better suited to that approach instead.

tzarc avatar Aug 13 '24 00:08 tzarc

Yeah ok, I get that. I'm using it for a calculator/numpad but I see there aren't a lot of other use cases.

NewAbbreviations950 avatar Aug 13 '24 02:08 NewAbbreviations950