qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

`atreus`: restore intended matrix implementations

Open noroadsleft opened this issue 1 year ago • 2 comments

Description

PR 24010 inadvertently changed the switch matrix for the atreus/astar_mirrored keyboard in removing the PCBDOWN configuration option, and also made PCB up and down implementations available for all Atreus variants, which is not intended usage.

This commit restores the intended behaviour, and makes all the keymaps which are currently present agnostic to hardware variant.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [x] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft avatar Jul 08 '24 22:07 noroadsleft

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

tzarc avatar Aug 26 '24 10:08 tzarc

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Oct 12 '24 02:10 github-actions[bot]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

github-actions[bot] avatar Nov 12 '24 02:11 github-actions[bot]

Looks good pending revert of VIA keymap changes.

fauxpark avatar Nov 12 '24 04:11 fauxpark

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Dec 29 '24 02:12 github-actions[bot]

... kinda completely forgot about this PR.

noroadsleft avatar Oct 04 '25 06:10 noroadsleft