qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add new board km75

Open Smartmmd opened this issue 1 year ago • 5 comments

Description

Add new board km17

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Smartmmd avatar Jun 22 '24 09:06 Smartmmd

Just a heads up, the PR was flagged with "needs-wireless-code", as this board may appear to be a BT/tri mode board.

As such, the code to communicate with the BT/Wireless chip needs to be present to be in compliance with the GPL licensing that QMK is under. Note, the code for the wireless chip isn't necessary, just the code to communicate with it.

drashna avatar Jul 04 '24 20:07 drashna

It not a wireless board. copy a keymap from others with ble keycode by mistake. already removed thanks

JackyJia73 avatar Jul 05 '24 08:07 JackyJia73

Also, your licence headers are all over the place and should really be consistent. Sorry, I will modify.

JackyJia73 avatar Jul 05 '24 13:07 JackyJia73

On hold due to ambiguity with wireless, and definitive evidence of 2/3 wireless boards based on QMK with no sources. See #24085 for rationale -- if we're holding the others back, this one should too.

tzarc avatar Jul 14 '24 05:07 tzarc

Wireless code added

JackyJia73 avatar Jul 22 '24 02:07 JackyJia73

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

tzarc avatar Aug 26 '24 10:08 tzarc