qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Addition of Daisy V2 Macropad

Open ghostseven opened this issue 1 year ago • 5 comments

Description

Addition of a Daisy V2 MacroPad with rotary encoder and OLED display on a STM32 base.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ghostseven avatar Jun 13 '24 15:06 ghostseven

Hey @chrisvanmook , the getPayloadHMR arg typing is a bit too wide here. It is not intended to change options other than the config and the importMap. We'll be trimming up this type to avoid any confusion here.

denolfe avatar Aug 23 '24 14:08 denolfe

Hey @chrisvanmook , the getPayloadHMR arg typing is a bit too wide here. It is not intended to change options other than the config and the importMap. We'll be trimming up this type to avoid any confusion here.

Ah that makes sense! However, how should I be able to set these initial options with NextJS, since we only have the RootLayout component that initiates payload?

chrisvanmook avatar Aug 23 '24 14:08 chrisvanmook

Ideally, most of these values should be able to be set in the config itself. I'll be investigating this, since it doesn't look like the logger options can be set in the config currently.

denolfe avatar Aug 24 '24 13:08 denolfe

Hi @denolfe, do you perhaps have any updates on this?

chrisvanmook avatar Sep 10 '24 13:09 chrisvanmook

This issue has been marked as stale due to lack of activity.

To keep this issue open, please indicate that it is still relevant in a comment below.

github-actions[bot] avatar Dec 13 '24 05:12 github-actions[bot]

This issue was automatically closed due to lack of activity.

github-actions[bot] avatar Dec 21 '24 05:12 github-actions[bot]