qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add support for Kami65 PCB

Open MaiTheSan opened this issue 1 year ago • 4 comments

Description

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

MaiTheSan avatar May 01 '24 23:05 MaiTheSan

Per the PR checklist,

  • PRs should contain the smallest amount of modifications required for a single change to the codebase
    • multiple keyboards at the same time is not acceptable

zvecr avatar May 02 '24 01:05 zvecr

Per the PR checklist,

  • PRs should contain the smallest amount of modifications required for a single change to the codebase

    • multiple keyboards at the same time is not acceptable

got it

MaiTheSan avatar May 02 '24 05:05 MaiTheSan

please:

  1. rename keyboards/chickenman/kami65/info.json to keyboards/chickenman/kami65/keyboard.json
  2. delete keyboards/chickenman/kami65/rules.mk

As so this PR conforms to the recent changes regarding build markers.

dunk2k avatar May 31 '24 12:05 dunk2k

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

tzarc avatar Aug 26 '24 10:08 tzarc