qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

[Refactor] Consolidate `wt65_h{1,2,3,4}` into `wt65_h`

Open waffle87 opened this issue 1 year ago • 3 comments

Description

wilba_tech/wt65_h{1,2,3} (and 4 -- #23610) all only differ in layout. This combines them into one keyboard with multiple layouts, and migrates to JSON keymaps.

Types of Changes

  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87 avatar Apr 26 '24 01:04 waffle87

If each PCB revision supports different physical layouts, or combinations of, then these should not be combined into a single revision.

zvecr avatar Apr 26 '24 01:04 zvecr

I suggested #23610 and pretty new to qmk. This is what I'm seeing: h1 - Loaded 2 layers and 132 keycodes. Defined 0 Any key keycodes. h2 - Loaded 4 layers and 264 keycodes. Defined 0 Any key keycodes. h3 - Loaded 2 layers and 132 keycodes. Defined 0 Any key keycodes.

What values are these numbers based on?

anyway, should I still test this branch @waffle87, or are you going in a different direction?

MrLys avatar Apr 29 '24 06:04 MrLys

I've tested it now. I can flash it, but the keymappings are off. Backspace button is KC_NUHS, Enter is KC_BSPC. Space doesn't work. alt gr / Right alt doesn't work, but is switched with the key next to it. Capslock is R_CTRL. Escape key is not QK_GESC as it should be on this keyboard.

MrLys avatar Apr 29 '24 08:04 MrLys