qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add KB09 keyboard

Open DOIO2022 opened this issue 10 months ago • 1 comments

Description

Add KB09 keyboard

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

DOIO2022 avatar Apr 19 '24 09:04 DOIO2022

Is there a reason for the removed keyboards? If not, those changes should be reverted.

I made an operation error and only partially reverted, so I manually reverted.

DOIO2022 avatar Apr 30 '24 10:04 DOIO2022

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jun 15 '24 01:06 github-actions[bot]

  • Changes to other keyboards must be reverted

    • This has previously been requested and is still outstanding
    • kb38 changes should be submitted separately

Hi , I've reverted the kb38 info.json . Please review again, Thank you!

DOIO2022 avatar Jun 20 '24 06:06 DOIO2022

There are other files that are modified and still need to be reverted. This can easily be shown on the "Files Changed" tab.

zvecr avatar Jun 20 '24 07:06 zvecr

There are other files that are modified and still need to be reverted. This can easily be shown on the "Files Changed" tab.

QQ截图20240620192739 @zvecr I committed these files on the browser, can you tell me how I revert these , I can't find the revert button. Thank you so much!

DOIO2022 avatar Jun 20 '24 11:06 DOIO2022