Add Kiiboom loop65
Description
Types of Changes
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement/optimization
- [x] Keyboard (addition or update)
- [ ] Keymap/layout/userspace (addition or update)
- [ ] Documentation
Issues Fixed or Closed by This PR
Checklist
- [x] My code follows the code style of this project: C, Python
- [ ] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
This appears to be exactly the same keyboard as epomaker/tide65? (#23356)
diff loop65/info.json epomaker/tide65/info.json
3c3
< "keyboard_name": "KIIBOOM LOOP 65",
---
> "keyboard_name": "EPOMAKER TIDE 65",
Common subdirectories: loop65/keymaps and epomaker/tide65/keymaps
Only in loop65: loop65.c
diff loop65/readme.md epomaker/tide65/readme.md
1c1
< # KIIBOOM LOOP 65
---
> # EPOMAKER TIDE 65
4,5c4,5
< * Hardware Supported: KIIBOOM LOOP 65
< * Hardware Availability: [kiiboom](https://www.kiiboom.com)
---
> * Hardware Supported: EPOMAKER TIDE 65
> * Hardware Availability: [epomaker](https://www.epomaker.com)
9c9
< make kiiboom/loop65:default
---
> make epomaker/tide_65:default
13c13
< make kiiboom/loop65:default:flash
---
> make epomaker/tide65:default:flash
Only in epomaker/tide65: tide65.c
This appears to be exactly the same keyboard as
epomaker/tide65? (#23356)diff loop65/info.json epomaker/tide65/info.json 3c3 < "keyboard_name": "KIIBOOM LOOP 65", --- > "keyboard_name": "EPOMAKER TIDE 65", Common subdirectories: loop65/keymaps and epomaker/tide65/keymaps Only in loop65: loop65.c diff loop65/readme.md epomaker/tide65/readme.md 1c1 < # KIIBOOM LOOP 65 --- > # EPOMAKER TIDE 65 4,5c4,5 < * Hardware Supported: KIIBOOM LOOP 65 < * Hardware Availability: [kiiboom](https://www.kiiboom.com) --- > * Hardware Supported: EPOMAKER TIDE 65 > * Hardware Availability: [epomaker](https://www.epomaker.com) 9c9 < make kiiboom/loop65:default --- > make epomaker/tide_65:default 13c13 < make kiiboom/loop65:default:flash --- > make epomaker/tide65:default:flash Only in epomaker/tide65: tide65.c
I understand that you require clarification regarding the nature of my submission. To confirm, the provided code pertains to the QMK configuration for two distinct keyboard models. Please inform me if this submission violates any guidelines or policies. Thank you for your attention to this matter.
As far the firmware is concerned, they are not distinct keyboards at all, which may not violate any policies per se, but that doesn't mean there are no issues. For example, can you explain the need for the code in keyboards/kiiboom/loop65/loop65.c? Another thing, these keyboards share the exact same VID/PID, which will likely cause issues with things like VIA. The list can go on.
If this is identical to a tide65, then it's a trimode board. On hold until we find out if that's the case.
This PR is on hold until #24085 is rectified.
As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.
As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.