qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Allow codegen of `keymap.json` => `keymap.c` without requiring layers/layout etc.

Open tzarc opened this issue 2 years ago • 2 comments

Description

Allows for keymap.c to coexist with keymap.json. Anything in keymap.json will take precedence and supplying stuff in both will cause failures, but that comes with the territory.

Have migrated the onekey console keymap so that there's at least one keymap in-tree.

Minimal keymap.json could be something like this:

{
    "converter": "promicro_rp2040",
    "config": {
        "features": {
            "unicode": true
        }
    }
}

...with a corresponding keymap.c as per normal usage patterns.

Types of Changes

  • [x] Core
  • [ ] Bugfix
  • [ ] New feature
  • [x] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tzarc avatar Apr 10 '24 12:04 tzarc

Moved back to draft until I get time to sort out test failures etc. Need to go digging as per Z's comment.

Across the org: https://github.com/search?q=org%3Aqmk+KEYMAP_GOES_HERE&type=code

tzarc avatar May 19 '24 04:05 tzarc

Cleared draft state. Seems like it's now properly working both inside qmk_firmware and inside qmk_userspace.

tzarc avatar Aug 14 '24 02:08 tzarc

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Oct 03 '24 02:10 github-actions[bot]