qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Added noll/multisteno

Open igniuss opened this issue 10 months ago • 2 comments

Description

Added a new keyboard, so I can use the QMK configurator,

the main problem is that I do not own this keyboard, but it hasn't been updated since QMK 1.1.1, so I'm not sure what the etiquette for that is.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

igniuss avatar Apr 06 '24 21:04 igniuss

Configurator is a very poor tool for such a keyboard.

Technically you can PR someone else's code but copyright needs to be preserved and added to by you.

However, the code you have submitted requires significant updates to be valid. Some insight to this can be seen in why the Lint checks and CI checks are failing below.

You also need to go through the PR checklist carefully, and ensure you have actioned all the relevant points in it, and then check the box in the Checklist above. Only then will it be considered ready for initial review.

keyboard-magpie avatar Apr 06 '24 22:04 keyboard-magpie

I just want to thank you so much @zvecr for the time and patience; doing all of this is very overwhelming, and your assistance is super appreciated 😍

igniuss avatar Apr 07 '24 22:04 igniuss