qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard
verified publisher icon qmk

Adds keyboard ergodox_extended

Open Gephorian opened this issue 1 year ago • 12 comments

Description

This adds the Ergodox Extended, a version of the ErgoDox that adds F-keys and expands the thumb cluster. Keyboard hardware repo is here. Firmware is almost entirely based on keyboards/handwired/pterodactyl, since that was very cleanly written and easy to modify.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Gephorian avatar Mar 24 '24 23:03 Gephorian

I think that's everything, if I missed anything please let me know and I'll get it sorted asap.

Gephorian avatar Mar 24 '24 23:03 Gephorian

@fauxpark Ready for re-review.

Gephorian avatar Mar 26 '24 00:03 Gephorian

Alrighty, got all those changes committed. How are we looking?

Gephorian avatar Mar 26 '24 14:03 Gephorian

Anything left to do here?

Gephorian avatar Mar 26 '24 15:03 Gephorian

I think this is ready for review/merge, all the changes requested have been made and it's looking pretty sharp. If there's anything else I need on it, let me know and I can get it fixed up immediately.

Gephorian avatar Mar 26 '24 20:03 Gephorian

Ready for merge?

Gephorian avatar Mar 27 '24 13:03 Gephorian

Done. I think that should be the last thing, right?

Gephorian avatar Mar 27 '24 14:03 Gephorian

Good morning! This is ready for a review. Let me know if anything else needs to be changed. I'd love to get this merged this week if possible.

Gephorian avatar Mar 28 '24 16:03 Gephorian

Anyone free to have a look at this and let me know if anything else needs to be changed?

Gephorian avatar Apr 02 '24 18:04 Gephorian

(note: I don't know enough about the custom matrix to comment on it one way or the other, but everything else seems fine.)

lesshonor avatar Apr 05 '24 23:04 lesshonor

At the very least, the custom matrix works as intended. I've been typing on it for a bit.

Gephorian avatar Apr 06 '24 02:04 Gephorian

This has been approved for a month. Can I get this merged in?

Gephorian avatar May 07 '24 15:05 Gephorian

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jun 22 '24 01:06 github-actions[bot]

Commenting to remove stale label, still in need of review.

Gephorian avatar Jun 22 '24 02:06 Gephorian

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Aug 07 '24 01:08 github-actions[bot]

:wave: This got marked as stale again, is there anything else to be done? I'd love to get this merged in. Thank you!

Gephorian avatar Aug 07 '24 02:08 Gephorian

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Sep 22 '24 02:09 github-actions[bot]

Hello,

This got marked as stale again. Please mark it as awaiting review. Thanks

Gephorian avatar Sep 22 '24 02:09 Gephorian

Alright, going to close this PR until I have time to look at this again. Thanks for the review.

Gephorian avatar Sep 22 '24 22:09 Gephorian