qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

[Keyboard] Add efreet Redux

Open Druah opened this issue 1 year ago • 6 comments

Description

Added efreet Redux PCB, with VIA support.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Druah avatar Mar 05 '24 03:03 Druah

Not sure why my readme and blank rules.mk file are apparently missing formatting ¯\_(ツ)_/¯

Druah avatar Mar 05 '24 03:03 Druah

@Druah Could I ask as to why suggestions, including addition of Community Layout support, were reverted?

dunk2k avatar Mar 05 '24 17:03 dunk2k

@Druah Could I ask as to why suggestions, including addition of Community Layout support, were reverted?

On second thought I didn't see a need for them since neither the sole user of the PCB and or the handful of people it will be going to will be using said community layouts.

Druah avatar Mar 05 '24 17:03 Druah

On second thought I didn't see a need for them since neither the sole user of the PCB and or the handful of people it will be going to will be using said community layouts.

I would implore at a minimum the ortho_4x12 Community Layout is added, as this PCB's key switch arrangement is identical to that layout.

Regarding the planck_mit Community Layout, could I refer you to the Keyboard section of the PR Checklist, in particular this excerpt:

  • If the keyboard only has a single electrical/switch layout:
    • use LAYOUT as your macro name, unless a community layout already exists
  • If the keyboard has multiple electrical/switch layouts:
    • include a LAYOUT_all which specifies all possible layout positions in the electrical matrix
    • use alternate layout names for all other possible layouts, preferring community layout names if an equivalent is available (e.g. LAYOUT_tkl_ansi, LAYOUT_ortho_4x4 etc.)

dunk2k avatar Mar 05 '24 21:03 dunk2k

@zvecr If I could get a re-review that would be great, thanks 👍

Druah avatar Mar 13 '24 13:03 Druah

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jul 13 '24 01:07 github-actions[bot]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Sep 20 '24 02:09 github-actions[bot]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

github-actions[bot] avatar Oct 20 '24 02:10 github-actions[bot]