qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard
verified publisher icon qmk

Added Skyloong/GK61 pro dual space keyboard.

Open NaturalZh opened this issue 1 year ago • 24 comments

GK61 pro double space keyboard

Description

The Skyloong GK61 PRO dual space key keyboard has two 3.125 split space bars. It can be replaced with a long space bar of 6.25.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

NaturalZh avatar Jan 30 '24 08:01 NaturalZh

What else can I do about merging PR?

NaturalZh avatar Mar 22 '24 10:03 NaturalZh

What can I do for this PR else ?

NaturalZh avatar Apr 22 '24 06:04 NaturalZh

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jun 09 '24 01:06 github-actions[bot]

Please review it again @fauxpark

NaturalZh avatar Jun 17 '24 07:06 NaturalZh

Would you please check this PR and what can I do else ? @zvecr @fauxpark

NaturalZh avatar Jul 23 '24 03:07 NaturalZh

This looks really good to me!

iamdanielv avatar Aug 21 '24 20:08 iamdanielv

This looks really good to me!

Thank you for your help. @iamdanielv

NaturalZh avatar Aug 22 '24 00:08 NaturalZh

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them.

Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones?

@zvecr @fauxpark

iamdanielv avatar Aug 26 '24 06:08 iamdanielv

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them.

Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones?

@zvecr @fauxpark

I think maybe the via keymaps can be contributed in qmk_userspace_via repository . But it`s now read only.

NaturalZh avatar Aug 27 '24 01:08 NaturalZh

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them. Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones? @zvecr @fauxpark

I think maybe the via keymaps can be contributed in qmk_userspace_via repository . But it`s now read only.

You have to make the PR for the via keymap on the the-via/qmk_userspace_via repo actually as the one you linked to is used as an archive, @NaturalZh.

adophoxia avatar Aug 27 '24 18:08 adophoxia

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them. Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones? @zvecr @fauxpark

I think maybe the via keymaps can be contributed in qmk_userspace_via repository . But it`s now read only.

You have to make the PR for the via keymap on the the-via/qmk_userspace_via repo actually as the one you linked to is used as an archive, @NaturalZh.

OK, I see. Thanks for informing us. It seem that it don`t accept PR at present. @adophoxia

NaturalZh avatar Aug 28 '24 01:08 NaturalZh

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them. Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones? @zvecr @fauxpark

I think maybe the via keymaps can be contributed in qmk_userspace_via repository . But it`s now read only.

You have to make the PR for the via keymap on the the-via/qmk_userspace_via repo actually as the one you linked to is used as an archive, @NaturalZh.

OK, I see. Thanks for informing us. It seem that it don`t accept PR at present. @adophoxia

If we're still on the same page of https://github.com/the-via/qmk_userspace_via, then it does actually accept PRs.

adophoxia avatar Aug 28 '24 01:08 adophoxia

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them. Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones? @zvecr @fauxpark

I think maybe the via keymaps can be contributed in qmk_userspace_via repository . But it`s now read only.

You have to make the PR for the via keymap on the the-via/qmk_userspace_via repo actually as the one you linked to is used as an archive, @NaturalZh.

OK, I see. Thanks for informing us. It seem that it don`t accept PR at present. @adophoxia

If we're still on the same page of https://github.com/the-via/qmk_userspace_via, then it does actually accept PRs.

I submitted PR to try it out. Thank you. @adophoxia

NaturalZh avatar Aug 28 '24 01:08 NaturalZh