qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

refactor: keyboard/ncr80/r2

Open lesshonor opened this issue 1 year ago • 7 comments

Description

There is a Round 3 of this keyboard which I am preparing for submission, so move (and refactor slightly) the original Round 2 folder.

  • Unnecessary blank layers removed from via keymaps
  • Basically-identical readmes consolidated
  • Feature list moved to ~~info.json~~ keyboard.json

The only substantive change is enabling mousekeys by default on both versions and RGB Light on the hotswap version, so Configurator users can easily make use of these features.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

lesshonor avatar Dec 15 '23 15:12 lesshonor

add Community Layout support

Please see previous response regarding this subject. I don't have the background information on this keyboard and don't have time to research it; my only goal is to get it moved so R3 can be added.

lesshonor avatar Jan 20 '24 20:01 lesshonor

add Community Layout support

Please see previous response regarding this subject. I don't have the background information on this keyboard and don't have time to research it; my only goal is to get it moved so R3 can be added.

I've done the research and had added these changes to a community_layout PR of mine but seeing as said PR includes multiple keyboards, these changes would be better placed in a PR that focus solely on keyboard in question.

dunk2k avatar Jan 20 '24 20:01 dunk2k

I've done the research and had added these changes to a community_layout PR of mine but seeing as said PR includes multiple keyboards, these changes would be better placed in a PR that focus solely on keyboard in question.

OK, if you've confirmed the PCB wiring, I'll accept the changes. Thanks!

lesshonor avatar Jan 20 '24 20:01 lesshonor

OK, if you've confirmed the PCB wiring, I'll accept the changes. Thanks!

Thank you kindly 🙂

dunk2k avatar Jan 21 '24 01:01 dunk2k

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Mar 06 '24 01:03 github-actions[bot]

if someone could mark as awaiting review, that would be appreciated.

lesshonor avatar Mar 06 '24 01:03 lesshonor

Restructured folder with an eye toward the changes made in #22891 and eventually #23281.

I don't see a particular problem with simply eliminating DEFAULT_FOLDER in this case, though would appreciate input from collaborators. The solder and hotswap build targets have always been separate, and the make commands in the readme files have always specified the full path (...which has been appropriately amended in keyboard_aliases). It seems unlikely the shortcut target was widely used.

lesshonor avatar Mar 15 '24 01:03 lesshonor

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jun 25 '24 01:06 github-actions[bot]

if someone could mark as awaiting review, that would be appreciated.

lesshonor avatar Jun 26 '24 03:06 lesshonor