qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

[Keyboard] Refactor Helix

Open waffle87 opened this issue 2 years ago • 4 comments

Description

  • Removes legacy code such as define's
  • Removes unnecessary and complicated makefiles
  • Adds keyboard level code that is used across revisions (keycodes and OLED behaviour)
  • Formatting on lots of files

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87 avatar Dec 11 '23 19:12 waffle87

I do like a good optimisation 😊

Could I be a cheeky (so and so) and ask for the following amendments:

  1. image URL in keyboards/helix/readme.md have the added h before .jpg?
  2. glcdfont.c is missing licence information in header, could it be added?

dunk2k avatar Dec 11 '23 21:12 dunk2k

Probably want @mtei to chime in on this one.

tzarc avatar Jan 09 '24 11:01 tzarc

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

tzarc avatar Aug 26 '24 10:08 tzarc