qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Addition of MariViper v2/3, and consolidation to "toril940" projects folder.

Open ninetailedtori opened this issue 1 year ago • 3 comments

Description

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ninetailedtori avatar Nov 16 '23 17:11 ninetailedtori

@toril940 Moving of keyboard(s) into another directory, in this case mariorion v2.5 into 'toril940' directory, would have to be done with a separate PR based to develop branch 🙂

dunk2k avatar Nov 16 '23 23:11 dunk2k

@toril940 Moving of keyboard(s) into another directory, in this case mariorion v2.5 into 'toril940' directory, would have to be done with a separate PR based to develop branch 🙂

Say it ain't so, SAY IT AIN'T SO 😭 can I just add a develop branch change here? 🥺 @dunk2k

ninetailedtori avatar Nov 22 '23 16:11 ninetailedtori

Say it ain't so, SAY IT AIN'T SO 😭 can I just add a develop branch change here? 🥺 @dunk2k

You could change base branch of this PR to develop - it would mean that changes here would be merged, from develop, into master branch during next breaking changes cycle (Feb 2024).

I would advise if there is a commercial dependency to this PR, then the keyboard addition is added to master branch as its own PR, and directory change made in separate PR based to develop branch. 🙂

dunk2k avatar Nov 22 '23 16:11 dunk2k

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Feb 29 '24 01:02 github-actions[bot]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Apr 15 '24 02:04 github-actions[bot]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

github-actions[bot] avatar May 16 '24 01:05 github-actions[bot]