qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add Wookong WK87

Open Gyphae opened this issue 2 years ago • 9 comments

Description

Add Wookong WK87, an ansi version of 87 keys keyboard with two encoders.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Gyphae avatar Oct 28 '23 13:10 Gyphae

From the PR checklist:

  • PRs should contain the smallest amount of modifications required for a single change to the codebase
    • multiple keyboards at the same time is not acceptable

The document also covers additional changes that must be made.

zvecr avatar Oct 28 '23 20:10 zvecr

Updated PR checklist and delete wk104.

Gyphae avatar Oct 30 '23 09:10 Gyphae

@dunk2k @zvecr @drashna Hello, if there are any other modification suggestions for this project?

kingcanace avatar Nov 24 '23 06:11 kingcanace

Changes have been made based on your suggestions. @dunk2k @zvecr @drashna

Gyphae avatar Dec 03 '23 14:12 Gyphae

@zvecr @drashna @dunk2k need your help to review this PR, we have another keyboard waiting for adding into repo, thanks!

Gyphae avatar Dec 09 '23 06:12 Gyphae

Please don't close and open new PRs because you haven't had responses. Next time both will be closed.

tzarc avatar Dec 11 '23 03:12 tzarc

Thanks!@tzarc

Gyphae avatar Dec 11 '23 05:12 Gyphae

we have another keyboard waiting for adding into repo

Why would this PR block another?

Your use of master is somewhat against the PR checklist suggestion, and makes additional PR more complicated but not impossible.

zvecr avatar Dec 13 '23 06:12 zvecr

@fauxpark @zvecr We have finished all requested changes for a long time, pls approve, thanks!

Gyphae avatar Jul 15 '24 08:07 Gyphae

@fauxpark We have finished your new requested changes, pls approve, thanks!

Gyphae avatar Jul 23 '24 09:07 Gyphae

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

tzarc avatar Aug 26 '24 10:08 tzarc

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Oct 11 '24 02:10 github-actions[bot]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

github-actions[bot] avatar Nov 10 '24 02:11 github-actions[bot]