qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Published 20 hours ago • verified publisher icon qmk

Add RGB matrix & LED Matrix support for IS31FL3729

Open HorrorTroll opened this issue 11 months ago • 5 comments

Description

Added support IS31FL3729 LED driver for both RGB Matrix and LED Matrix, was tested and work perfectly on my board. Updated docs with how to configure new features.

Types of Changes

  • [x] Core
  • [ ] Bugfix
  • [x] New feature
  • [x] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [x] Documentation

Issues Fixed or Closed by This PR

  • #21850

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

HorrorTroll avatar Sep 07 '23 07:09 HorrorTroll

needs formatting to pass lint

dexter93 avatar Sep 07 '23 08:09 dexter93

needs formatting to pass lint

Thanks for review, I've just redone formatting lint

HorrorTroll avatar Sep 07 '23 12:09 HorrorTroll

Thanks for review, fauxpark. I've just push a new commit to resolve your suggested.

HorrorTroll avatar Sep 23 '23 15:09 HorrorTroll

I've just resolve conflicted issue. Can i have another review on this PR? Thanks

HorrorTroll avatar Nov 07 '23 03:11 HorrorTroll

I've just resolved issues. Can i have another review on this PR? Thanks!

HorrorTroll avatar Dec 13 '23 12:12 HorrorTroll