qmk_firmware
qmk_firmware copied to clipboard
add 64_(ansi|iso) Community Layouts in keyboards
Description
- add respective 64 Community Layout(s) to board with same layout name and matching key matrix information.
- where applicable, renamed layout name to Community Layout name, alias added
- applicable 60_* Community Layouts included, as not to clash (merge conflict) with other 60_ Community Layout PRs
- correct ISO Enter key sequence in
layouts
, and keymap if applicable, for ISO layouts - add
matrix_diagram.md
for multiple layout boards, where accurate information is available - add (if missing) or change image URL (if link broken) in
readme.md
, where image available
Keyboard specific:
- DZ60:
- changed layout macro names in keymaps to match respective
layout
- removed
60_abnt2
layout; this board doesn't support 1u-1.75u RShift
- changed layout macro names in keymaps to match respective
Types of Changes
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement/optimization
- [x] Keyboard (addition or update)
- [ ] Keymap/layout/userspace (addition or update)
- [ ] Documentation
Issues Fixed or Closed by This PR
- n/a
Checklist
- [x] My code follows the code style of this project: C, Python
- [x] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
Hi @yj7272098 , I've moved Community Layout support addition for playkbtw/pk60 to this PR.
When you're able, in keyboards/playkbtw/pk60/matrix_diagram.md
:
- Could you confirm matrix co-ordinates for identified key positions are correct?
- I've noticed key positions, and their respective widths, I've not been able to identify; using v3 PCB as reference. Would you be able to oblige adding key positions, with their matrix co-ordinates, that I've been unable to identify?
Hi, I don't really understand what you mean. Do you mean the mapping between keys and the matrix? Sorry, English is not my mother language@@
From @.*** +886 975691197
Duncan Sutherland @.***> 於 2023年12月11日 週一 上午12:51寫道:
@sennin32 https://github.com/sennin32 Hi, if you're able, and would be greatly appreciated, could you relay matrix co-ordinates for ?? keys in keyboards/do60/matrix_diagram.md?
— Reply to this email directly, view it on GitHub https://github.com/qmk/qmk_firmware/pull/21832#issuecomment-1849018336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWADIEWCHLCM6NBJ23SALDYIXR7VAVCNFSM6AAAAAA35S5BKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZGAYTQMZTGY . You are receiving this because you were mentioned.Message ID: @.***>
Hi, I don't really understand what you mean. Do you mean the mapping between keys and the matrix? Sorry, English is not my mother language@@ From @.*** +886 975691197 Duncan Sutherland @.***> 於 2023年12月11日 週一 上午12:51寫道:
Hi @sennin32,
In this PR, could you look at file keyboards/do60/matrix_diagram.md
and confirm, in a comment, that the matrix co-ordinates for each key are correct?