Keyboard/kb04

[filmstarr]

Description

Added new keyboard KB04-01, made by DOIO. Extending https://github.com/qmk/qmk_firmware/pull/17739 to add RGB LEDs.

Types of Changes

• [ ] Core
• [ ] Bugfix
• [ ] New feature
• [ ] Enhancement/optimization
• [x] Keyboard (addition or update)
• [x] Keymap/layout/userspace (addition or update)
• [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

• [x] My code follows the code style of this project: C, Python
• [x] I have read the PR Checklist document and have made the appropriate changes.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[zvecr]

Why have you added extra matrix pins when addressing LED issues? The macropad hasnt magically gained any additional switches.

[filmstarr]

Why have you added extra matrix pins when addressing LED issues? The macropad hasnt magically gained any additional switches.

I must not be understanding something. There are more LEDs than switches (8 LEDs vs 4 switches + 1 encoder), but I get a build error if I have more LEDs than pins in MATRIX_COL_PINS (error: excess elements in the array initializer). It seems to me like the RGB matrix is sized off of MATRIX_ROW_PINS/MATRIX_COL_PINS.

[zvecr]

Compiles fine, as you can see with 39b1f4b, (which you should pull down locally).

[filmstarr]

Ahh, I understand! @zvecr, pulled your change and that works perfectly! 👌 Thanks for your patience.

[github-actions[bot]]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[zqad]

Hi, For what it's worth, I tested this branch with my KB04 and it works just perfectly with every keymap and LED setup I threw at it. Thanks @filmstarr!

[github-actions[bot]]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[zqad]

Hi, Anything that I could help test or so, before this PR gets auto-closed? Would be nice to get this merged :)

[github-actions[bot]]

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[github-actions[bot]]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

[vinorodrigues]

#22754