qmk_firmware
qmk_firmware copied to clipboard
[Keymap] manna-harbour_miryoku RESET to QK_BOOT
Description
Change RESET to QK_BOOT in user/manna-harbour_miryoku
Clears way for CI on #18751.
Types of Changes
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement/optimization
- [ ] Keyboard (addition or update)
- [x] Keymap/layout/userspace (addition or update)
- [ ] Documentation
Issues Fixed or Closed by This PR
Checklist
- [x] My code follows the code style of this project: C, Python
- [x] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
@manna-harbour, FYI. RESET is being deprecated and PRs of keyboards using manna-harbour_miryoku run into continuous integration test failures without this change.
Thanks for the fix! It was missed in https://github.com/qmk/qmk_firmware/pull/18560.
However, it's already been fixed in the miryoku
branch in https://github.com/manna-harbour/miryoku_qmk/commit/cb156972fa64f4b89d5cc672ba65bd33dc4b634d, and making the change here will cause a conflict when merging master
and break using the Miryoku QMK build workflow merge branch feature with branches based on master
(e.g. https://github.com/manna-harbour/miryoku_qmk/actions/runs/3269345107/jobs/5376747070#step:4:118).
Here's a PR to update Miryoku including this fix: https://github.com/qmk/qmk_firmware/pull/18758. Please merge that PR instead.
Thanks!