qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add darkproject/kd83a_bfg_edition keyboard

Open gskygithub opened this issue 3 years ago • 1 comments

Description

Add darkproject/kd83a_bfg_edition keyboard.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

gskygithub avatar Sep 19 '22 09:09 gskygithub

@fauxpark , Resolved requested changes. Could you please help me to take a look. Thanks

gskygithub avatar Oct 11 '22 02:10 gskygithub

Can someone please take a look at this PR please.

gskygithub avatar Oct 24 '22 01:10 gskygithub

@fauxpark, please take a look at this PR please. Thanks

gskygithub avatar Dec 26 '22 01:12 gskygithub

@fauxpark I didn't get you, could you please explain in detail what are the changes I need to do in this pull request.

gskygithub avatar Jan 17 '23 01:01 gskygithub

The suggestions above still need to be accepted.

fauxpark avatar Jan 17 '23 01:01 fauxpark

@gksygithub, I have a release version of this keyboard, it uses a different mcu WB32FQ95 20221230_012818

Serega2009bk avatar Jan 24 '23 17:01 Serega2009bk

@fauxpark I didn't get you, could you please explain in detail what are the changes I need to do in this pull request.

Look closely at the files. You accidentally uploaded an additional kd83a_bfg_edition folder inside the darkproject/kd83a_bfg_edition instead of replacing the files that were there. You should delete this extra folder.

Also, you don't have to upload replacement files. You can accept the changes from fauxpark by following the instructions on this page: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes

lesshonor avatar Jan 24 '23 18:01 lesshonor

My board also came with WB32FQ95

SHVD3x avatar Jan 25 '23 02:01 SHVD3x

@Serega2009bk, @SHVD3x, yes it is correct MCU (WB32FQ95). updated json file, Thanks.

gskygithub avatar Feb 01 '23 10:02 gskygithub

@drashna , @fauxpark , please take a look at this PR. Thanks.

gskygithub avatar Feb 08 '23 01:02 gskygithub

@fauxpark , Resolved requested changes. Please take a look, thanks.

gskygithub avatar Feb 13 '23 07:02 gskygithub

@fauxpark Resolved requested changes, thanks.

gskygithub avatar Feb 15 '23 10:02 gskygithub

@fauxpark Can you please help to review the changes, thanks.

gskygithub avatar Mar 08 '23 04:03 gskygithub

Can someone take a look at this PR please..., thanks.

gskygithub avatar Mar 22 '23 08:03 gskygithub

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jun 11 '23 02:06 github-actions[bot]

@fauxpark, please take a look at this PR, thanks.

gskygithub avatar Jun 12 '23 01:06 gskygithub

@fauxpark , Could you please take a look at this PR, thanks.

gskygithub avatar Jul 24 '23 01:07 gskygithub

@drashna @fauxpark , still is there any modifications in this PR? please kindly help to review or merge it, thanks.

gskygithub avatar Aug 25 '23 01:08 gskygithub

@drashna @fauxpark @lesshonor @noroadsleft, can someone please take a look at this PR please.

gskygithub avatar Nov 07 '23 10:11 gskygithub

Thanks!

noroadsleft avatar Nov 22 '23 22:11 noroadsleft