qmk_firmware
qmk_firmware copied to clipboard
Keychron q6
Add new keyboard q6 which contains four sub versions.
Description
- Add keyboard rev_0160, ansi version of q6.
- Add keyboard rev_0161, ansi version of q6 and enable encoder ec11.
- Add keyboard rev_0162, iso version of q6.
- Add keyboard rev_0163, iso version of q6 and enable encoder ec11.
Types of Changes
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement/optimization
- [x] Keyboard (addition or update)
- [x] Keymap/layout/userspace (addition or update)
- [ ] Documentation
Issues Fixed or Closed by This PR
Checklist
- [x] My code follows the code style of this project: C, Python
- [x] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
Hi, just bought a q6 and was wandering what the status of this pr is?
Is there anything actually blocking this merge, or are we just waiting on someone to push the button at this point?
Is there anything actually blocking this merge, or are we just waiting on someone to push the button at this point?
We're in discussion to help simplify long-term maintenance of the Keychron submissions. Bear with us.
Are you sure, these layouts (layout macro names) are correct? The Q6 is Fullsize (+F13) + 4 Buttons above the Numpad. Does not seem to be a standard layout you can find here: https://github.com/qmk/qmk_firmware/tree/master/layouts/default
Here is an image of the non-knob version (no F13): https://www.keychron.com/pages/keychron-q6-keycap-size
I can confirm that the Q6 is not a TKL layout. It has the layout shown in your link.
(and I'm typing this on one, so i'm pretty confident of that.)
It's basically fullsize_ISO/ansi with 4 additional keys above the numpad.
I just flashed a build of this firmware (VIA version) on a Q6 ISO Knob. Now I am unable to remap the rotation of the encoder. Remapping of pressing the knob works, though.
Edit I was using this keymap: https://cdn.shopify.com/s/files/1/0059/0630/1017/files/Q6_UK_ISO_Knob_V1.2.json.zip
I was able to fix this by adding a proper definition of the encoder to the via json: Q6_UK_ISO_Knob_V1.2-mod.zip
Result:
I was able to fix this by adding a proper definition of the encoder to the via json: Q6_UK_ISO_Knob_V1.2-mod.zip
Result:
This was because they were using the action_exec
hack that was used before encoder mapping to mimic encoder actions, which in this case, was probably why your knob wasn't working since the JSON used was for that hack, @kroegerama
Any ideas on when this is going to be merged?
I own a Q6, and I was wondering which QMK revision it was shipped with. I want to develop some custom stuff and I see that QMK for Q6 is still in active development, which is quite weird considering Q6s have been being shipped for while now.
Also (hijacking this thread a bit) - since the Q6 doesn't have num/caps lock LED indicators, is there an easy way for QMK to indicate these via RGB? i.e. Making the alpha keys glow with red if caps lock is on.
Also (hijacking this thread a bit) - since the Q6 doesn't have num/caps lock LED indicators, is there an easy way for QMK to indicate these via RGB? i.e. Making the alpha keys glow with red if caps lock is on.
You can use the inbuilt caps/numlock feature of this keychron branch (activated key glows white): https://github.com/Keychron/qmk_firmware/blob/d451b4282a335499208ba651fba20fad1a601ac8/keyboards/keychron/q6/iso_encoder/config.h#L40
You could also use this snippet and add it to the q6 code. I once added it to a GMMK Pro to have all Alpha-Keys light red, if the Capslock is active: https://github.com/qmk/qmk_firmware/blob/master/docs/feature_rgb_matrix.md#indicator-examples-idindicator-examples
Any ideas on when this is going to be merged?
Would like to know this as well 🙂
can someone please help check this? we have a lot of customers that need this one to be merged. thanks for your time. Appreciate it!
can this be merged now?