qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Published 20 hours ago • verified publisher icon qmk

[Keyboard]modify ginkgo65

Open Runheme opened this issue 1 year ago • 2 comments

Description

Types of Changes

  • [x] Core
  • [x] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [x] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ ] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Runheme avatar Jul 26 '22 00:07 Runheme

@rhmokey could you confirm this change is correct, or would this be better handled as a new revision?

zvecr avatar Jul 26 '22 01:07 zvecr

It looks like you may be attempting to morph ginkgo65 (the soldered version of the pcb) into ginkgo65hot (the hot swap version). Perhaps there is some confusion here? Are you working on the soldered, or hotswap version?

spidey3 avatar Aug 01 '22 00:08 spidey3