qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add RAW_HID_CMD option when VIA is enabled

Open lokher opened this issue 2 years ago • 3 comments

Description

Add RAW_HID_CMD option when VIA is enabled so that there will be more flexibility to use customized hid command.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [ ] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ ] My code follows the code style of this project: C, Python
  • [ ] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

lokher avatar Jul 14 '22 06:07 lokher

There would potentially be longer term maintenance issues if via attempts to extend the IDs they use, and expand into something that is also configured for RAW_HID_CMD.

Also to note, VIA protocol is to be deprecated soonish.

zvecr avatar Jul 14 '22 13:07 zvecr

QMK CI Run, PR #17680

Commit SHA1: 98b5f4c64742cd0f87acf63633ced7fd88adb7e3
  Base SHA1: 7501523e1f7d99c3abf3efbe2ad88cb4bac51367

Build succeeded. See the CI output for more information.

qmk-ci[bot] avatar Jul 14 '22 23:07 qmk-ci[bot]

@lokher after talking with @vinorodrigues about this, the changes to the VIA protocol for VIA V3 can support what you want to do - being able to override the default handling and do your own thing in the keyboard level code. You could use custom values rather than new commands.

Please have a look at the VIA V3 changes. We will be doing a PR to QMK after the current breaking change event.

https://www.caniusevia.com/docs/v3_changes

https://github.com/wilba/qmk_firmware/tree/via_protocol_11

wilba avatar Jul 31 '22 01:07 wilba