qmk_firmware
qmk_firmware copied to clipboard
[Keymap] Update keyboards/planck/keymaps/ariccb with new features and layout
Made some major overhaul and additions to my previous PR for my keymap, and would like them included on the master branch. It feels complete now.
Description
I am not using all the keys on the planck - it is to emulate the crkbrd (corne) layout to help me know that I would like that form factor after switching to a split board from planck. In addition, the changes here will allow me to have a consistent experience switching from a corne split to my planck, so keeping one at home and one in the office will be convenient and won't require me to think too much about which board I am using.
Types of Changes
keymap layout changes, new features (to my keymap, not to QMK in general)
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement/optimization
- [ ] Keyboard (addition or update)
- [x] Keymap/layout/userspace (addition or update)
- [ ] Documentation
Issues Fixed or Closed by This PR
Checklist
- [x] My code follows the code style of this project: C, Python
- [x] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
You have some merge conflicts here that need to be resolved first.
Additionally, caps word is a core feature, so the custom code should be removed.
It looks like this was based on develop, but not targeting develop.
Also, you have some submodule issues, and merge conflicts.
This has a number of merge conflicts, as well as changes to the submodules that shouldn't be included.
You may need to rebase your branch here.
Changing target back to master, since merged.
However, this has a bunch of merge conflicts still, that need resolving.
Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug
, awaiting review
, breaking_change
, in progress
, or on hold
to prevent the issue from being re-flagged.
Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug
, awaiting review
, breaking_change
, in progress
, or on hold
to prevent the issue from being re-flagged.
Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]