qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Added support for the Shisaku keyboard.

Open ADPenrose opened this issue 2 years ago • 3 comments

Description

Added support for the Shisaku keyboard; a 40% alice-like keyboard, assembled only with THT components, featuring a solenoid that brings back that cozy typewriter feel.

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

  • As this is the first PR regarding the kintsugi keyboard, no issue has been fixed or closed yet.

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

ADPenrose avatar Jul 06 '22 02:07 ADPenrose

Were the added changes sufficient and correct?

ADPenrose avatar Jul 24 '22 03:07 ADPenrose

Compiled and flashed on different hardware and everything works just as expected.

ADPenrose avatar Jul 24 '22 23:07 ADPenrose

Were the added changes correct?

ADPenrose avatar Jul 29 '22 18:07 ADPenrose

Were the added changes right?

ADPenrose avatar Aug 02 '22 22:08 ADPenrose

Do I need to modify something else so that this keyboard is merged?

ADPenrose avatar Aug 05 '22 15:08 ADPenrose

Is everything correct?

ADPenrose avatar Aug 06 '22 16:08 ADPenrose

Thanks!

drashna avatar Aug 07 '22 21:08 drashna