qmk_firmware
qmk_firmware copied to clipboard
emdashii keymap working
Description
I fixed bugs with the crkbd/keymaps/emdashiiAnimation keymap, and completely rebuild crkbd/keymaps/emdashii keymap, for a corne keyboard with LEDs. emdashiiAnimation is for a corne keyboard with no LEDs. The animation is on the OLED screen. emdashii lights up different keys depending on which layer the keyboard is on. This is really helpful in keyboard use. There are also more layers in emdashii than emdashiiAnimation.
Types of Changes
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement/optimization
- [ ] Keyboard (addition or update)
- [x ] Keymap/layout/userspace (addition or update)
- [ ] Documentation
Issues Fixed or Closed by This PR
Checklist
- [x ] My code follows the code style of this project: C, Python
- [x ] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
I added a bitmap logo to my emdashii keymap.
It looks like you have changes to the submodules here. These need to be reverted before the PR can be approved.
Rebasing sometimes will fix this. Otherwise, you'd want to do something like this to fix them:
git checkout master
git submodule foreach 'git log -n1 --oneline'
# remember the first abcdef1234 on the submodules that have an issue
git checkout @@your-branch@@
# for each of the problematic repo's:
cd lib/@@name@@
git checkout abcdef1234
Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug
, awaiting review
, breaking_change
, in progress
, or on hold
to prevent the issue from being re-flagged.
Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]